feat: new active projects api for export tool #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitijrajsharma
requested changes
Dec 12, 2023
backend/api/projects/resources.py
Outdated
| 500: | ||
| description: Internal Server Error | ||
| """ | ||
| interval = int(request.args.get("interval", 24)) |
There was a problem hiding this comment.
We need to add validation for the interval
backend/services/project_service.py
Outdated
|
|
||
| @staticmethod | ||
| def get_active_projects(interval): | ||
| action_date = datetime.now() - timedelta(hours=interval) |
There was a problem hiding this comment.
I assume datetime.now() is in UTC ?
backend/api/projects/resources.py
Outdated
| default: Token sessionTokenHere== | ||
| - name: interval | ||
| in: path | ||
| description: Time interval to get active project |
There was a problem hiding this comment.
time interval in hours
kshitijrajsharma
requested changes
Dec 13, 2023
| @@ -1197,6 +1197,9 @@ def get(self): | |||
| 500: | |||
| description: Internal Server Error | |||
| """ | |||
| interval = int(request.args.get("interval", 24)) | |||
| interval = request.args.get("interval", "24") | |||
| if not interval.isdigit(): | |||
There was a problem hiding this comment.
0 and <=24 restrict user to extract more than 24 hour active projects
| result = ( | ||
| TaskHistory.query.with_entities(TaskHistory.project_id) | ||
| .distinct() | ||
| .filter(TaskHistory.action_date >= action_date) |
There was a problem hiding this comment.
Using this , test this query with dump of production database , you might need action_date btree timestamp index
kshitijrajsharma
approved these changes
Jan 8, 2024
|
@kaditya97 Can you make sure that backend tests are passing ? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New endpoint to generate a list of active projects
endpoint: /projects/queries/active/
query parameter:
interval: default to 24 hours
fix Export tool integration: Creating a new endpoint to generate a list of active projects #6144